On Sat, Dec 08, 2007 at 05:21:00PM -0600, Matt Mackall wrote:
> random: improve variable naming, clear extract buffer
>
> - split the SHA variables apart into hash and workspace
> - rename data to extract
> - wipe extract and workspace after hashing
>
> diff -r 924f9a441236 drivers/char/random.c
> --- a/drivers/char/random.c Sat Dec 08 16:22:29 2007 -0600
> +++ b/drivers/char/random.c Sat Dec 08 16:32:31 2007 -0600
> @@ -461,7 +461,7 @@ static void __add_entropy_words(struct e
> unsigned long flags;
> /* rotate the add pointer more rapidly to span more of the
> * pool on a given add */
> - const int step = 5;
> + const int step = 13;
>
> /* Taps are constant, so we can load them without holding r->lock. */
> tap1 = r->poolinfo->tap1;
This change has nothing to do with the patch comment. If you want to
change the step size from 5 to 13, why not just change patch 5/6 to
just use a step size of 13 from the beginning?
Otherwise, yeah, this patch does make sense.
Acked-by: "Theodore Ts'o" <[EMAIL PROTECTED]>
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
