From: Joseph Qi <joseph...@linux.alibaba.com>

commit 7067b2619017d51e71686ca9756b454de0e5826a upstream.

It takes xattr_sem to check inline data again but without unlock it
in case not have. So unlock it before return.

Fixes: aef1c8513c1f ("ext4: let ext4_truncate handle inline data correctly")
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Cc: Tao Ma <boyu...@taobao.com>
Signed-off-by: Joseph Qi <joseph...@linux.alibaba.com>
Reviewed-by: Andreas Dilger <adil...@dilger.ca>
Link: 
https://lore.kernel.org/r/1604370542-124630-1-git-send-email-joseph...@linux.alibaba.com
Signed-off-by: Theodore Ts'o <ty...@mit.edu>
Cc: sta...@kernel.org
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 fs/ext4/inline.c |    1 +
 1 file changed, 1 insertion(+)

--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1892,6 +1892,7 @@ void ext4_inline_data_truncate(struct in
 
        ext4_write_lock_xattr(inode, &no_expand);
        if (!ext4_has_inline_data(inode)) {
+               ext4_write_unlock_xattr(inode, &no_expand);
                *has_inline = 0;
                ext4_journal_stop(handle);
                return;


Reply via email to