Hello Rob, > On Thu, 12 Nov 2020 17:04:20 +0100, Gregory CLEMENT wrote: >> Convert device tree bindings for Microsemi Ocelot SoC ICPU Interrupt >> Controller to YAML format >> >> Signed-off-by: Gregory CLEMENT <gregory.clem...@bootlin.com> >> --- >> .../mscc,ocelot-icpu-intr.txt | 21 ------- >> .../mscc,ocelot-icpu-intr.yaml | 59 +++++++++++++++++++ >> 2 files changed, 59 insertions(+), 21 deletions(-) >> delete mode 100644 >> Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.txt >> create mode 100644 >> Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.yaml >> > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/interrupt-controller/mscc,ocelot-icpu-intr.yaml:59:4: > [error] no new line character at the end of file (new-line-at-end-of-file) > > dtschema/dtc warnings/errors: > make[1]: *** [Documentation/devicetree/bindings/Makefile:59: > Documentation/devicetree/bindings/processed-schema-examples.json] Error 123 > make: *** [Makefile:1364: dt_binding_check] Error 2 > > > See https://patchwork.ozlabs.org/patch/1399077 > > The base for the patch is generally the last rc1. Any dependencies > should be noted. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date:
I actually ran 'make dt_binding_check' and in the documentation there was no reference of Documentation/devicetree/writing-schema.rst the need of 'yamllint' while in the dependencies section of it was mentioned the need of 'libyaml-dev'. What do you think about updating the documentation ? > > pip3 install dtschema --upgrade > > Please check and re-submit. Sure I am doing it right now. Gregory > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
