Re: [PATCH v3 net-next 07/13] octeontx2-af: Add debugfs entry to dump the MCAM rules

[Naveen Mamindlapalli]

Hi Saeed,

> -----Original Message-----
> From: Saeed Mahameed <sa...@kernel.org>
> Sent: Friday, November 13, 2020 1:18 AM
> To: Naveen Mamindlapalli <nave...@marvell.com>; net...@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Cc: k...@kernel.org; da...@davemloft.net; Sunil Kovvuri Goutham
> <sgout...@marvell.com>; Linu Cherian <lcher...@marvell.com>;
> Geethasowjanya Akula <gak...@marvell.com>; Jerin Jacob Kollanukkaran
> <jer...@marvell.com>; Subbaraya Sundeep Bhatta <sbha...@marvell.com>;
> Hariprasad Kelam <hke...@marvell.com>
> Subject: Re: [PATCH v3 net-next 07/13] octeontx2-af: Add debugfs entry
> to dump the MCAM rules
> 
> On Wed, 2020-11-11 at 12:43 +0530, Naveen Mamindlapalli wrote:
> > From: Subbaraya Sundeep <sbha...@marvell.com>
> >
> > Add debugfs support to dump the MCAM rules installed using
> > NPC_INSTALL_FLOW mbox message. Debugfs file can display mcam entry,
> > counter if any, flow type and counter hits.
> >
> > Ethtool will dump the ntuple flows related to the PF only.
> > The debugfs file gives systemwide view of the MCAM rules installed by
> > all the PF's.
> >
> > Below is the example output when the debugfs file is read:
> > ~ # mount -t debugfs none /sys/kernel/debug ~ # cat
> > /sys/kernel/debug/octeontx2/npc/mcam_rules
> >
> >     Installed by: PF1
> >     direction: RX
> >         mcam entry: 227
> >     udp source port 23 mask 0xffff
> >     Forward to: PF1 VF0
> >         action: Direct to queue 0
> >     enabled: yes
> >         counter: 1
> >         hits: 0
> >
> 
> I don't want to block this series or anything, but you might want to use 
> devlink
> dpipe interface for this:
> 
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__www.kernel.org_doc_html_latest_networking_devlink_devlink-
> 2Ddpipe.html&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=TwreqwV6mQ8K9
> wIpqwFO8yjikO_w1jUOe2MzChg4Rmg&m=Q3bIaVBAvCHGU817Tap8T9ooBFRP
> CJhP9kvFODtUnJg&s=YV7Q2w0JHxg9RUdwJvMfjC063Umev9Hpb6YvNSbe37A&e
> =
> 
> As a future patch of course.

Thanks for the pointers. We will definitely look into adding the devlink dpipe 
support in future.

> 
> Thanks,
> Saeed.