Geert Uytterhoeven wrote: > On Wed, 5 Dec 2007, Geoff Levand wrote: >> Andrew Morton wrote: >> > On Wed, 5 Dec 2007 10:52:48 +0100 (CET) >> > Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: >> > >> >> -------------------------------------------------------------------------------- >> >> Subject: sparsemem: sparse_add_one_section() may fail to allocate memory >> >> >> >> sparsemem: sparse_add_one_section() may fail to allocate memory, and must >> >> check >> >> whether the allocation succeeded before proceeding to touch the allocated >> >> memory. >> >> >> >> From: Geert Uytterhoeven <[EMAIL PROTECTED]> >> >> >> >> Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> >> >> --- >> >> FIXME There are still some possible memory leaks in >> >> sparse_add_one_section(): >> >> - usemap is never deallocated >> >> - __kfree_section_memmap() is a not yet implemented dummy >> > >> > I already had >> > >> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/mm-sparsec-improve-the-error-handling-for-sparse_add_one_section.patch >> > and >> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/broken-out/mm-sparsec-check-the-return-value-of-sparse_index_alloc.patch >> > >> > queued. Do they fix the problem, and should they be merged in 2.6.24? >> >> No, a quick test shows it just panics in a different place. Geert's >> patch does also. > > What do you mean, that it still paniced after my patch? > > The kernel did boot succesfully for me when passing ps3fb=48M. Userspace saw > 58 > MiB (128 MiB - kernelsize - 48 MiB(ps3fb)). > > I did not try kexec, though.
On looking at it, your patch should have worked, so I guess I didn't boot the correct image, or something like that. Sorry. -Geoff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
