The operation type packet is complex and contains subclass; the parsing
flow causes deep indentation; for more readable, this patch introduces
a new function arm_spe_pkt_desc_op_type() which is used for operation
type parsing.
Signed-off-by: Leo Yan <leo....@linaro.org>
Reviewed-by: Andre Przywara <andre.przyw...@arm.com>
---
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 79 +++++++++++--------
1 file changed, 45 insertions(+), 34 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
index 64811021f36c..4f93b75c87e6 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
@@ -321,6 +321,50 @@ static int arm_spe_pkt_desc_event(const struct arm_spe_pkt
*packet,
return err;
}
+static int arm_spe_pkt_desc_op_type(const struct arm_spe_pkt *packet,
+ char *buf, size_t buf_len)
+{
+ u64 payload = packet->payload;
+ int err = 0;
+
+ switch (packet->index) {
+ case 0:
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len,
+ payload & 0x1 ? "COND-SELECT" : "INSN-OTHER");
+ break;
+ case 1:
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len,
+ payload & 0x1 ? "ST" : "LD");
+
+ if (payload & 0x2) {
+ if (payload & 0x4)
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, "
AT");
+ if (payload & 0x8)
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, "
EXCL");
+ if (payload & 0x10)
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, "
AR");
+ } else if (payload & 0x4) {
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, " SIMD-FP");
+ }
+ break;
+ case 2:
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, "B");
+
+ if (payload & 0x1)
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, " COND");
+ if (payload & 0x2)
+ arm_spe_pkt_snprintf(&err, &buf, &buf_len, " IND");
+
+ break;
+ default:
+ /* Unknown index */
+ err = -1;
+ break;
+ }
+
+ return err;
+}
+
static int arm_spe_pkt_desc_addr(const struct arm_spe_pkt *packet,
char *buf, size_t buf_len)
{
@@ -404,40 +448,7 @@ int arm_spe_pkt_desc(const struct arm_spe_pkt *packet,
char *buf,
err = arm_spe_pkt_desc_event(packet, buf, buf_len);
break;
case ARM_SPE_OP_TYPE:
- switch (idx) {
- case 0:
- arm_spe_pkt_snprintf(&err, &buf, &blen,
- payload & 0x1 ? "COND-SELECT" :
"INSN-OTHER");
- break;
- case 1:
- arm_spe_pkt_snprintf(&err, &buf, &blen,
- payload & 0x1 ? "ST" : "LD");
-
- if (payload & 0x2) {
- if (payload & 0x4)
- arm_spe_pkt_snprintf(&err, &buf, &blen,
" AT");
- if (payload & 0x8)
- arm_spe_pkt_snprintf(&err, &buf, &blen,
" EXCL");
- if (payload & 0x10)
- arm_spe_pkt_snprintf(&err, &buf, &blen,
" AR");
- } else if (payload & 0x4) {
- arm_spe_pkt_snprintf(&err, &buf, &blen, "
SIMD-FP");
- }
- break;
- case 2:
- arm_spe_pkt_snprintf(&err, &buf, &blen, "B");
-
- if (payload & 0x1)
- arm_spe_pkt_snprintf(&err, &buf, &blen, "
COND");
- if (payload & 0x2)
- arm_spe_pkt_snprintf(&err, &buf, &blen, " IND");
-
- break;
- default:
- /* Unknown index */
- err = -1;
- break;
- }
+ err = arm_spe_pkt_desc_op_type(packet, buf, buf_len);
break;
case ARM_SPE_DATA_SOURCE:
case ARM_SPE_TIMESTAMP:
--
2.17.1
