Re: [PATCH] drm/virtio: use kvmalloc for large allocations

[Sergey Senozhatsky]

Hi,

On (20/11/05 07:52), Gerd Hoffmann wrote:
> > -   *ents = kmalloc_array(*nents, sizeof(struct virtio_gpu_mem_entry),
> > -                         GFP_KERNEL);
> > +   *ents = kvmalloc_array(*nents,
> > +                          sizeof(struct virtio_gpu_mem_entry),
> > +                          GFP_KERNEL);
> 
> Shouldn't that be balanced with a kvfree() elsewhere?

I think it already is. ents pointer is assigned to vbuf->data_buf,
and free_vbuf() already uses kvfree(vbuf->data_buf) to free it.

        -ss