On Tue, 4 Dec 2007 14:21:00 -0500
Mathieu Desnoyers <[EMAIL PROTECTED]> wrote:
> > > + */
> > > +void marker_probe_cb(const struct marker *mdata, void *call_private,
> > > + const char *fmt, ...)
> > > +{
> > > + va_list args;
> > > + char ptype;
> > > +
> > > + preempt_disable();
> >
> > What are the preempt_disable()s doing in here?
> >
> > Unless I missed something obvious, a comment is needed here (at least).
> >
>
> They make sure the teardown of the callbacks can be done correctly when
> they are in modules and they insure RCU read coherency. Will add
> comment.
So shouldn't it be using rcu_read_lock()? If that does not suit, should we
be adding new rcu primitives rather than open-coding and adding dependencies?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
