On 10/26/20 1:31 AM, Dmitry Osipenko wrote: > 23.10.2020 13:26, Chanwoo Choi пишет: >> @@ -1401,8 +1423,13 @@ static ssize_t governor_store(struct device *dev, >> struct device_attribute *attr, >> "%s: reverting to Governor %s failed (%d)\n", >> __func__, df->governor_name, ret); >> df->governor = NULL; >> + goto out; >> } > ... >> + create_sysfs_files(df, df->governor); >> + goto out; > > These two lines could be removed.
Right. These are redundant code. It is possible to support with just fallback style. > >> } >> + create_sysfs_files(df, df->governor); >> + >> out: >> mutex_unlock(&devfreq_list_lock); > > Otherwise looks good to me. > > Reviewed-by: Dmitry Osipenko <dig...@gmail.com> > Tested-by: Dmitry Osipenko <dig...@gmail.com> > > -- Best Regards, Chanwoo Choi Samsung Electronics
