On Fri, Oct 23, 2020 at 04:47:08PM -0400, Rik van Riel wrote: > +++ b/include/linux/gfp.h > @@ -614,6 +614,8 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask); > extern void pm_restrict_gfp_mask(void); > extern void pm_restore_gfp_mask(void); > > +extern gfp_t alloc_hugepage_direct_gfpmask(struct vm_area_struct *vma);
Without the types, the name of this function makes me think it allocates something. Like alloc_hugepage_vma() does. With the types, it's obvious that it gets the gfpmask. Can this patch rename it, perhaps to gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma); (hugepage is also ambiguous because it might be for hugetlbfs and we use, eg, mapping_gfp_mask, not mapping_gfpmask).
