These tests omit field separators from the synthetic event definitions so don't follow the syntax '<event_name> field[;field] ...' required for synthetic events.
Fixes: f06eec4d0f2c (selftests: ftrace: Add inter-event hist triggers testcases) Signed-off-by: Tom Zanussi <zanu...@kernel.org> --- .../trigger/inter-event/trigger-inter-event-combined-hist.tc | 4 ++-- .../test.d/trigger/inter-event/trigger-onmatch-action-hist.tc | 2 +- .../trigger/inter-event/trigger-onmatch-onmax-action-hist.tc | 2 +- .../test.d/trigger/inter-event/trigger-trace-action-hist.tc | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-inter-event-combined-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-inter-event-combined-hist.tc index 9098f1e7433f..29a03ed3377d 100644 --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-inter-event-combined-hist.tc +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-inter-event-combined-hist.tc @@ -10,7 +10,7 @@ fail() { #msg echo "Test create synthetic event" -echo 'waking_latency u64 lat pid_t pid' > synthetic_events +echo 'waking_latency u64 lat; pid_t pid' > synthetic_events if [ ! -d events/synthetic/waking_latency ]; then fail "Failed to create waking_latency synthetic event" fi @@ -21,7 +21,7 @@ echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' > events/sched/s echo 'hist:keys=pid:waking_lat=common_timestamp.usecs-$ts0:onmatch(sched.sched_waking).waking_latency($waking_lat,pid) if comm=="ping"' > events/sched/sched_wakeup/trigger echo 'hist:keys=pid,lat:sort=pid,lat' > events/synthetic/waking_latency/trigger -echo 'wakeup_latency u64 lat pid_t pid' >> synthetic_events +echo 'wakeup_latency u64 lat; pid_t pid' >> synthetic_events echo 'hist:keys=pid:ts1=common_timestamp.usecs if comm=="ping"' >> events/sched/sched_wakeup/trigger echo 'hist:keys=next_pid:wakeup_lat=common_timestamp.usecs-$ts1:onmatch(sched.sched_wakeup).wakeup_latency($wakeup_lat,next_pid) if next_comm=="ping"' > events/sched/sched_switch/trigger diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-action-hist.tc index 20e39471052e..5015d0d74de8 100644 --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-action-hist.tc +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-action-hist.tc @@ -10,7 +10,7 @@ fail() { #msg echo "Test create synthetic event" -echo 'wakeup_latency u64 lat pid_t pid char comm[16]' > synthetic_events +echo 'wakeup_latency u64 lat; pid_t pid; char comm[16]' > synthetic_events if [ ! -d events/synthetic/wakeup_latency ]; then fail "Failed to create wakeup_latency synthetic event" fi diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-onmax-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-onmax-action-hist.tc index f4b03ab7c287..ac7ba2bbce47 100644 --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-onmax-action-hist.tc +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-onmatch-onmax-action-hist.tc @@ -10,7 +10,7 @@ fail() { #msg echo "Test create synthetic event" -echo 'wakeup_latency u64 lat pid_t pid char comm[16]' > synthetic_events +echo 'wakeup_latency u64 lat; pid_t pid; char comm[16]' > synthetic_events if [ ! -d events/synthetic/wakeup_latency ]; then fail "Failed to create wakeup_latency synthetic event" fi diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc index c126d2350a6d..76a213f197a0 100644 --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc @@ -10,7 +10,7 @@ fail() { #msg echo "Test create synthetic event" -echo 'wakeup_latency u64 lat pid_t pid char comm[16]' > synthetic_events +echo 'wakeup_latency u64 lat; pid_t pid; char comm[16]' > synthetic_events if [ ! -d events/synthetic/wakeup_latency ]; then fail "Failed to create wakeup_latency synthetic event" fi -- 2.17.1