On Thu, Nov 29, 2007 at 02:07:06AM +0100, Roel Kluin wrote: > in include/asm-arm/arch-omap/board-innovator.h:40 > #define NR_IRQS IH_BOARD_BASE + NR_FPGA_IRQS > > in include/asm-arm/arch-ixp23xx/irqs.h:156: > #define NR_IRQS NR_IXP23XX_IRQS + NR_IXP23XX_MACH_IRQS > > This could lead to problems when this definition is used in: > > arch/ia64/sn/kernel/irq.c:516: > sn_irq_lh = kmalloc(sizeof(struct list_head *) * NR_IRQS, GFP_KERNEL); > arch/x86/kernel/io_apic_32.c:693: > irq_cpu_data[i].irq_delta = kmalloc(sizeof(unsigned long) * NR_IRQS, > GFP_KERNEL); > 694: > irq_cpu_data[i].last_irq = kmalloc(sizeof(unsigned long) * NR_IRQS, > GFP_KERNEL); > 699: > memset(irq_cpu_data[i].irq_delta,0,sizeof(unsigned long) * NR_IRQS); > 700: > memset(irq_cpu_data[i].last_irq,0,sizeof(unsigned long) * NR_IRQS); > fs/proc/proc_misc.c:464: > per_irq_sum = kzalloc(sizeof(unsigned int)*NR_IRQS, GFP_KERNEL); > > I am not sure whether this definition actually is used in any of these files. > Am I being paranoya? anyway, adding parentheses should be safe. > -- > Add parentheses to prevent operator precedence errors > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
Acked-by: Lennert Buytenhek <[EMAIL PROTECTED]> Please send to the ARM patch system. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
