On Fri, Oct 16, 2020 at 05:59:04AM +0200, Miguel Ojeda wrote: > On Fri, Oct 16, 2020 at 4:33 AM Miguel Ojeda > <miguel.ojeda.sando...@gmail.com> wrote: > > > > Picking these for linux-next (including Rob's Reviewed-by). I have > > spotted a few typos that I corrected -- I will note them by email. > > Hmm, I think we should do another round instead, since I found what > looks to be an unintended revert of a previous commit in patch 24. > Lars, can you please take a look?
I will work on this soon. > Also, please take the chance to apply my comments given we have a new > round (and Rob's Reviewed-by too). Yes, of course. > By the way, I think you could simplify by squashing the "implement > hd44780_*" commits together (i.e. from 15 to 22 except 20), and the > two cleanups together too (i.e. 20 and 23). I know we asked you to > split things up before, but those two sets are quite similar > (including in their commit message) and easy to understand all > together. No problem. I will do this as well. Regards, Lars
