On 29/09/2020 14:39, Leo Yan wrote:
> Minor refactoring to use macro for index mask.
>
> Signed-off-by: Leo Yan <leo....@linaro.org>
Reviewed-by: Andre Przywara <andre.przyw...@arm.com>
Cheers,
Andre
> ---
> tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 2 +-
> tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> index b51a2207e4a0..00a2cd1af422 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> @@ -134,7 +134,7 @@ static int arm_spe_get_context(const unsigned char *buf,
> size_t len,
> struct arm_spe_pkt *packet)
> {
> packet->type = ARM_SPE_CONTEXT;
> - packet->index = buf[0] & 0x3;
> + packet->index = buf[0] & SPE_CTX_PKT_HDR_INDEX_MASK;
> return arm_spe_get_payload(buf, len, 0, packet);
> }
>
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
> b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
> index 88d2231c76da..62db4ff91832 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
> @@ -86,6 +86,9 @@ struct arm_spe_pkt {
> #define SPE_ADDR_PKT_INST_VA_EL2 (2)
> #define SPE_ADDR_PKT_INST_VA_EL3 (3)
>
> +/* Context packet header */
> +#define SPE_CTX_PKT_HDR_INDEX_MASK GENMASK_ULL(1, 0)
> +
> const char *arm_spe_pkt_name(enum arm_spe_pkt_type);
>
> int arm_spe_get_packet(const unsigned char *buf, size_t len,
>
