Re: [RESENDPATCH v1 2/6] spi: cadence-quadspi: Disable the DAC for Intel LGM SoC

[Pratyush Yadav]

On Tue, Oct 20 2020, Ramuthevar,Vadivel MuruganX wrote:

Hi,

> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthe...@linux.intel.com>
>
> On Intel Lightning Mountain(LGM) SoCs QSPI controller do not use
> Direct Access Controller(DAC).
>
> This patch adds a quirk to disable the Direct Access Controller
> for data transfer instead it uses indirect data transfer.
>
> Signed-off-by: Ramuthevar Vadivel Murugan 
> <vadivel.muruganx.ramuthe...@linux.intel.com>
> ---
>  drivers/spi/spi-cadence-quadspi.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/drivers/spi/spi-cadence-quadspi.c 
> b/drivers/spi/spi-cadence-quadspi.c
> index d7b10c46fa70..3d017b484114 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -1106,6 +1106,13 @@ static void cqspi_controller_init(struct cqspi_st 
> *cqspi)
>       reg |= CQSPI_REG_CONFIG_ENB_DIR_ACC_CTRL;
>       writel(reg, cqspi->iobase + CQSPI_REG_CONFIG);
>  
> +     /* Disable direct access controller */
> +     if (!cqspi->use_direct_mode) {
> +             reg = readl(cqspi->iobase + CQSPI_REG_CONFIG);
> +             reg &= ~CQSPI_REG_CONFIG_ENB_DIR_ACC_CTRL;
> +             writel(reg, cqspi->iobase + CQSPI_REG_CONFIG);
> +     }
> +
>       cqspi_controller_enable(cqspi, 1);
>  }
>  
> @@ -1388,6 +1395,10 @@ static const struct cqspi_driver_platdata am654_ospi = 
> {
>       .quirks = CQSPI_NEEDS_WR_DELAY,
>  };
>  
> +static const struct cqspi_driver_platdata intel_lgm_qspi = {
> +     .quirks = CQSPI_DISABLE_DAC_MODE,
> +};
> +
>  static const struct of_device_id cqspi_dt_ids[] = {
>       {
>               .compatible = "cdns,qspi-nor",
> @@ -1403,6 +1414,7 @@ static const struct of_device_id cqspi_dt_ids[] = {
>       },
>       {
>               .compatible = "intel,lgm-qspi",
> +             .data = &intel_lgm_qspi,
>       },
>       { /* end of table */ }
>  };

-- 
Regards,
Pratyush Yadav