Hi Andy, Thanks for the feedback.
>-----Original Message----- >From: Andy Shevchenko <andy.shevche...@gmail.com> >Sent: Thursday, October 8, 2020 4:46 PM >To: Zulkifli, Muhammad Husaini <muhammad.husaini.zulki...@intel.com> >Cc: Hunter, Adrian <adrian.hun...@intel.com>; Michal Simek ><michal.si...@xilinx.com>; Shevchenko, Andriy ><andriy.shevche...@intel.com>; Ulf Hansson <ulf.hans...@linaro.org>; linux- >mmc <linux-...@vger.kernel.org>; linux-arm Mailing List <linux-arm- >ker...@lists.infradead.org>; Linux Kernel Mailing List <linux- >ker...@vger.kernel.org>; Raja Subramanian, Lakshmi Bai ><lakshmi.bai.raja.subraman...@intel.com>; Wan Mohamad, Wan Ahmad Zainie ><wan.ahmad.zainie.wan.moha...@intel.com>; Arnd Bergmann ><a...@arndb.de> >Subject: Re: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted >Firmware Service call > >On Thu, Oct 8, 2020 at 5:48 AM <muhammad.husaini.zulki...@intel.com> wrote: >> >> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulki...@intel.com> >> >> Add header file to handle API function for device driver to >> communicate with Arm Trusted Firmware. > >Arm -> ARM ? I will rename based on Sudeep's mentioned in latest thread > >... > >> .../linux/firmware/intel/keembay_firmware.h | 47 +++++++++++++++++++ > >Please, drop dup of 'firmware' in the filename. Noted. Will change to keembay.h > >... > >> +/* >> + * Intel Keembay SOC Firmware API Layer >> + * > >> + * Copyright (C) 2020-2021, Intel Corporation > >Hello from the future? > Will edit to Copyright (C) 2020, Intel Corporation >> + * >> + * Muhammad Husaini Zulkifli <muhammad.husaini.zulki...@intel.com> > >Author: ... > >> + */ > >... > >> +/* >> + * This file defines API function that can be called by device driver >> +in order to > >an API >by a device Noted 😊 > >> + * communicate with Arm Trusted Firmware. > >Arm -> ARM ? I will rename based on Sudeep's mentioned in latest thread > >> + */ > >-- >With Best Regards, >Andy Shevchenko
