On 2020-09-30, Petr Mladek <pmla...@suse.com> wrote: > Anyway, I see hardcoded limit more like a hack. It limits something > somewhere so that some other code somewhere else is safe to use. > > And printk.c is really bad from this point. It sometimes does not > check for overflow because it "knows" that the buffers are big > enough. But it is error prone code, especially when there are more > limits defined (pure text, prefix, extended prefix). And it > will be worse if we allow to add more optional information > into the prefix.
So should I post a v3 where the checks are added? Or should I add comments where checks would be, explaining why the checks are not needed? John Ogness
