> > +# This makes sure the $(obj) subdirectory exists even though vdso32/ > > +# is not a kbuild sub-make subdirectory. > > +override obj-dirs = $(dir $(obj)) $(obj)/vdso32/ > > Should we teach kbuild to create dirs specified in targets? > Or we could 'fix' it so you do not need the override.
Something cleaner would be nice, yes. I'll leave it to you to decide. > use "set -e; in front of this shell script to bail out early > in case of errors. Back when I knew something about make, all commands ran with sh -ec. Ah, progress. Anyway, the one you cited does not have any commands that aren't tested with && or if already. set -e would have no effect. > > +VDSO_LDFLAGS = -fPIC -shared $(call ld-option, > > -Wl$(comma)--hash-style=sysv) > > Do you need to specify soname for 64-bit - seems missing? Using this rule for the 64-bit vDSO is not in this patch. Patch 18/18 defines VDSO_LDFLAGS_vdso.lds for this. > > +$(vdso-install-y): %.so: $(obj)/%.so.dbg FORCE > > @mkdir -p $(MODLIB)/vdso > > $(call cmd,vdso_install) > Please use $(Q) in preference for @ > Then it is easier to debug using make V=1 This line is not being changed in this patch, so that is really a separate question. Other places in other Makefiles use @mkdir too, so if you are concerned you could do a patch covering all of those. Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
