On Tue, 2020-09-29 at 15:14 +0200, Julia Lawall wrote:
> Replace commas with semicolons.  Commas introduce unnecessary
> variability in the code structure and are hard to see.  What is done
> is essentially described by the following Coccinelle semantic patch
> (http://coccinelle.lip6.fr/):
> 
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
> 
> Signed-off-by: Julia Lawall <[email protected]>
> 
> ---
>  drivers/media/platform/coda/coda-common.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/coda/coda-common.c 
> b/drivers/media/platform/coda/coda-common.c
> index eeba6c060981..1bb16cc0a823 100644
> --- a/drivers/media/platform/coda/coda-common.c
> +++ b/drivers/media/platform/coda/coda-common.c
> @@ -2861,7 +2861,7 @@ static int coda_register_device(struct coda_dev *dev, 
> int i)
>       strscpy(vfd->name, dev->devtype->vdevs[i]->name, sizeof(vfd->name));
>       vfd->fops       = &coda_fops;
>       vfd->ioctl_ops  = &coda_ioctl_ops;
> -     vfd->release    = video_device_release_empty,
> +     vfd->release    = video_device_release_empty;
>       vfd->lock       = &dev->dev_mutex;
>       vfd->v4l2_dev   = &dev->v4l2_dev;
>       vfd->vfl_dir    = VFL_DIR_M2M;
> 
> 

Thank you,

Reviewed-by: Philipp Zabel <[email protected]>

regards
Philipp

Reply via email to