Sorry for that offence, I should ask for your permission. -----Original Message----- From: Joe Perches <j...@perches.com> Sent: Sunday, September 27, 2020 5:14 PM To: Zhao, Haifeng <haifeng.z...@intel.com>; bhelg...@google.com; ooh...@gmail.com; rus...@russell.cc; lu...@wunner.de; andriy.shevche...@linux.intel.com; stuart.w.ha...@gmail.com; mr.nuke...@gmail.com; mika.westerb...@linux.intel.com Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Jia, Pei P <pei.p....@intel.com>; ashok....@linux.intel.com; Kuppuswamy, Sathyanarayanan <sathyanarayanan.kuppusw...@intel.com>; h...@infradead.org Subject: Re: [PATCH 4/5 V4] PCI: only return true when dev io state is really changed
On Sun, 2020-09-27 at 04:27 -0400, Ethan Zhao wrote: > When uncorrectable error happens, AER driver and DPC driver interrupt > handlers likely call > > pcie_do_recovery() > ->pci_walk_bus() > ->report_frozen_detected() > > with pci_channel_io_frozen the same time. > If pci_dev_set_io_state() return true even if the original state is > pci_channel_io_frozen, that will cause AER or DPC handler re-enter the > error detecting and recovery procedure one after another. > The result is the recovery flow mixed between AER and DPC. > So simplify the pci_dev_set_io_state() function to only return true > when dev->error_state is changed. > > Signed-off-by: Ethan Zhao <haifeng.z...@intel.com> > Tested-by: Wen Jin <wen....@intel.com> > Tested-by: Shanshan Zhang <shanshanx.zh...@intel.com> > Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > Reviewed-by: Alexandru Gagniuc <mr.nuke...@gmail.com> > Reviewed-by: Joe Perches <j...@perches.com> Hi Ethan/Haifeng. Like Andy, I did not "review" this patch and sign it. I merely suggested another simplification. Please do not add -by: lines unless actually received by you.
