RE: [PATCH 4/5 V2] PCI: only return true when dev io state is really changed

[Zhao, Haifeng]

😊  definitely simpler !

-----Original Message-----
From: Joe Perches <j...@perches.com> 
Sent: Sunday, September 27, 2020 12:17 PM
To: Zhao, Haifeng <haifeng.z...@intel.com>; bhelg...@google.com; 
ooh...@gmail.com; rus...@russell.cc; lu...@wunner.de; 
andriy.shevche...@linux.intel.com; stuart.w.ha...@gmail.com; 
mr.nuke...@gmail.com; mika.westerb...@linux.intel.com
Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Jia, Pei P 
<pei.p....@intel.com>; ashok....@linux.intel.com; Kuppuswamy, Sathyanarayanan 
<sathyanarayanan.kuppusw...@intel.com>
Subject: Re: [PATCH 4/5 V2] PCI: only return true when dev io state is really 
changed

On Sat, 2020-09-26 at 23:28 -0400, Ethan Zhao wrote:
> simplify the pci_dev_set_io_state() function to only return true when 
> dev->error_state is changed.
[]
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
[]
> @@ -362,35 +362,11 @@ static inline bool pci_dev_set_io_state(struct pci_dev 
> *dev,
>       bool changed = false;
[]
> +     if (dev->error_state == new)
> +             return changed;
> +
> +     dev->error_state = new;
> +     changed = true;
>       return changed;
>  }

This would be simpler removing the unnecessary changed automatic

...

        if (dev->error_state == new)
                return false;

        dev->error_state = new;

        return true;
}