Hi Geert,
Thank you for your feedback!
> From: Geert Uytterhoeven <ge...@linux-m68k.org>
> Sent: 23 September 2020 11:07
>
> Hi Fabrizio,
>
> On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro
> <fabrizio.castro...@renesas.com> wrote:
> > Convert the Renesas DRIF bindings to DT schema and update
> > MAINTAINERS accordingly.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro...@renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-
> lad...@bp.renesas.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
>
> > +properties:
>
> > + pinctrl-0:
> > + maxItems: 1
> > +
> > + pinctrl-names:
> > + maxItems: 1
> > + items:
> > + - const: default
>
> I think these are added automatically by the tooling, so there is no
> need to list them explicitly.
> Or do you need to list them here because of the required logic below?
I have now tried taking pinctrl-0 and pinctrl-names properties out, and things
seem to be okay, I'll take them out in v3.
>
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - resets
> > + - dmas
> > + - dma-names
> > + - renesas,bonding
>
> Missing "power-domains".
I'll add it in v3
>
> > +
> > +if:
> > + required:
> > + - renesas,primary-bond
> > +then:
> > + required:
> > + - pinctrl-0
> > + - pinctrl-names
> > + - port
>
> The last 3 properties must not be present for a secondary interface,
> right?
If you have both channels enabled, then one of the two has to define properties:
* renesas,primary-bond, pinctrl-0, pinctrl-names, and port.
If only one channel is enabled, then the primary bond concept loses its value,
whether renesas,primary-bond is specified or not doesn’t matter anymore, but the
enabled node has to specify the pinctrl related properties and the port.
> To express that, I think you need to add:
>
> else:
> properties:
> - pinctrl-0: false
> - pinctrl-names: false
> - port: false
If I went with this, we would not be able to allow those properties to be
specified in the
only enabled node for single channels configurations.
Is there a better way to approach this?
I'll wait for this point to get sorted before sending v3 out.
Thanks,
Fab
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch,
Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472
Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB
3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg.
no.: DE 14978647
