From: Xie XiuQi <xiexi...@huawei.com> [ Upstream commit 07e9a6f538cbeecaf5c55b6f2991416f873cdcbd ]
Need to free "str" before return when asprintf() failed to avoid memory leak. Signed-off-by: Xie XiuQi <xiexi...@huawei.com> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Cc: Hongbo Yao <yaohon...@huawei.com> Cc: Jiri Olsa <jo...@redhat.com> Cc: Li Bin <huawei.li...@huawei.com> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Namhyung Kim <namhy...@kernel.org> Link: http://lore.kernel.org/lkml/20200521133218.30150-4-liwei...@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <a...@redhat.com> Signed-off-by: Sasha Levin <sas...@kernel.org> --- tools/perf/util/sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index 84a33f1e9ec92..cd870129131e1 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -2667,7 +2667,7 @@ static char *prefix_if_not_in(const char *pre, char *str) return str; if (asprintf(&n, "%s,%s", pre, str) < 0) - return NULL; + n = NULL; free(str); return n; -- 2.25.1
