On 9/7/20 2:10 AM, Baolin Wang wrote: > Hi All, > > This patch set did some clean-ups, as well as removing some unnecessary > bps/iops limitation calculation when checking if can dispatch a bio or > not for a tg. Please help to review. Thanks. > > Baolin Wang (5): > blk-throttle: Fix some comments' typos > blk-throttle: Use readable READ/WRITE macros > blk-throttle: Define readable macros instead of static variables > blk-throttle: Avoid calculating bps/iops limitation repeatedly > blk-throttle: Avoid checking bps/iops limitation if bps or iops is > unlimited > > block/blk-throttle.c | 59 > ++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 36 insertions(+), 23 deletions(-)
Looks reasonable to me, I've applied it. Out of curiosity, are you using blk-throttle in production, or are these just fixes/cleanups that you came across? -- Jens Axboe
