On 08/21/2020 04:44 AM, Tingwei Zhang wrote:
From: Kim Phillips <kim.phill...@arm.com>Allow to build coresight-funnel as module, for ease of development. - combine static and dynamic funnel init into single module_init/exit call - add funnel_remove functions, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier <mathieu.poir...@linaro.org> Cc: Leo Yan <leo....@linaro.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Cc: Randy Dunlap <rdun...@infradead.org> Cc: Suzuki K Poulose <suzuki.poul...@arm.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Russell King <li...@armlinux.org.uk> Co-developed-by: Mian Yousaf Kaukab <ykau...@suse.de> Signed-off-by: Mian Yousaf Kaukab <ykau...@suse.de> Signed-off-by: Kim Phillips <kim.phill...@arm.com> Signed-off-by: Tingwei Zhang <ting...@codeaurora.org> Reported-by: kernel test robot <l...@intel.com> Tested-by: Mike Leach <mike.le...@linaro.org> Reviewed-by: Mathieu Poirier <mathieu.poir...@linaro.org> --- .../hwtracing/coresight/coresight-funnel.c | 64 ++++++++++++++++++- 1 file changed, 62 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index 900690a9f7f0..07bc20391fac 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -274,6 +274,15 @@ static int funnel_probe(struct device *dev, struct resource *res) return ret; }+static int __exit funnel_remove(struct device *dev)+{ + struct funnel_drvdata *drvdata = dev_get_drvdata(dev); + + coresight_unregister(drvdata->csdev); + + return 0; +} + #ifdef CONFIG_PM static int funnel_runtime_suspend(struct device *dev) { @@ -319,20 +328,32 @@ static int static_funnel_probe(struct platform_device *pdev) return ret; }+static int __exit static_funnel_remove(struct platform_device *pdev)+{ + funnel_remove(&pdev->dev); + pm_runtime_disable(&pdev->dev); + return 0; +} + static const struct of_device_id static_funnel_match[] = { {.compatible = "arm,coresight-static-funnel"}, {} };+MODULE_DEVICE_TABLE(of, static_funnel_match);+ #ifdef CONFIG_ACPI static const struct acpi_device_id static_funnel_ids[] = { {"ARMHC9FE", 0}, {}, }; + +MODULE_DEVICE_TABLE(acpi, static_funnel_ids); #endifstatic struct platform_driver static_funnel_driver = {.probe = static_funnel_probe, + .remove = static_funnel_remove, .driver = { .name = "coresight-static-funnel", .of_match_table = static_funnel_match,
Sorry missed this. Please set the owner field here. With that : Reviewed-by: Suzuki K Poulose <suzuki.poul...@arm.com>
