On Mon, Nov 12, 2007 at 02:46:30PM -0500, Mike Frysinger wrote: > the current checkpatch.pl does not reject new files that lack a > newline, yet rejects patches that fix newlines in files ... quite the > opposite of what we actually want
[EMAIL PROTECTED] echo -n "moo" >no-newline.c [EMAIL PROTECTED] diff -Nu /dev/null no-newline.c | ./checkpatch.pl -q -no-tree --no-signoff - WARNING: adding a line without newline at end of file #4: FILE: no-newline.c:1: +moo total: 0 errors, 1 warnings, 1 lines checked [EMAIL PROTECTED] echo "moo" >newline.c [EMAIL PROTECTED] diff -Nu no-newline.c newline.c | ./checkpatch.pl -q -no-tree --no-signoff - total: 0 errors, 0 warnings, 3 lines checked [EMAIL PROTECTED] This should be fixed in the 0.12 release and is fixed in -next. -apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/