Hi Luc, I love your patch! Perhaps something to improve:
[auto build test WARNING on 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5] url: https://github.com/0day-ci/linux/commits/Luc-Van-Oostenryck/sparse-use-static-inline-for-__chk_-user-io-_ptr/20200828-165431 base: 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5 config: i386-randconfig-s001-20200828 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-191-g10164920-dirty # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> sparse warnings: (new ones prefixed by >>) >> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: sparse: incorrect type in >> argument 1 (different address spaces) @@ expected void const volatile >> [noderef] __user *ptr @@ got char *buf @@ >> drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: expected void const >> volatile [noderef] __user *ptr drivers/w1/slaves/w1_ds28e04.c:342:13: sparse: got char *buf >> drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: sparse: incorrect type in >> argument 1 (different address spaces) @@ expected void const volatile >> [noderef] __user *ptr @@ got char const *buf @@ drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: expected void const volatile [noderef] __user *ptr drivers/w1/slaves/w1_ds28e04.c:356:13: sparse: got char const *buf # https://github.com/0day-ci/linux/commit/7d01c91ac34a64f0177bc6d058cc50e805f59102 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Luc-Van-Oostenryck/sparse-use-static-inline-for-__chk_-user-io-_ptr/20200828-165431 git checkout 7d01c91ac34a64f0177bc6d058cc50e805f59102 vim +342 drivers/w1/slaves/w1_ds28e04.c fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 338 fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 339 static ssize_t crccheck_show(struct device *dev, struct device_attribute *attr, fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 340 char *buf) fbf7f7b4e2ae40 Markus Franke 2012-05-26 341 { fbf7f7b4e2ae40 Markus Franke 2012-05-26 @342 if (put_user(w1_enable_crccheck + 0x30, buf)) fbf7f7b4e2ae40 Markus Franke 2012-05-26 343 return -EFAULT; fbf7f7b4e2ae40 Markus Franke 2012-05-26 344 fbf7f7b4e2ae40 Markus Franke 2012-05-26 345 return sizeof(w1_enable_crccheck); fbf7f7b4e2ae40 Markus Franke 2012-05-26 346 } fbf7f7b4e2ae40 Markus Franke 2012-05-26 347 fa33a65a9cf7e2 Greg Kroah-Hartman 2013-08-21 348 static ssize_t crccheck_store(struct device *dev, struct device_attribute *attr, fbf7f7b4e2ae40 Markus Franke 2012-05-26 349 const char *buf, size_t count) fbf7f7b4e2ae40 Markus Franke 2012-05-26 350 { fbf7f7b4e2ae40 Markus Franke 2012-05-26 351 char val; fbf7f7b4e2ae40 Markus Franke 2012-05-26 352 fbf7f7b4e2ae40 Markus Franke 2012-05-26 353 if (count != 1 || !buf) fbf7f7b4e2ae40 Markus Franke 2012-05-26 354 return -EINVAL; fbf7f7b4e2ae40 Markus Franke 2012-05-26 355 fbf7f7b4e2ae40 Markus Franke 2012-05-26 @356 if (get_user(val, buf)) fbf7f7b4e2ae40 Markus Franke 2012-05-26 357 return -EFAULT; fbf7f7b4e2ae40 Markus Franke 2012-05-26 358 fbf7f7b4e2ae40 Markus Franke 2012-05-26 359 /* convert to decimal */ fbf7f7b4e2ae40 Markus Franke 2012-05-26 360 val = val - 0x30; fbf7f7b4e2ae40 Markus Franke 2012-05-26 361 if (val != 0 && val != 1) fbf7f7b4e2ae40 Markus Franke 2012-05-26 362 return -EINVAL; fbf7f7b4e2ae40 Markus Franke 2012-05-26 363 fbf7f7b4e2ae40 Markus Franke 2012-05-26 364 /* set the new value */ fbf7f7b4e2ae40 Markus Franke 2012-05-26 365 w1_enable_crccheck = val; fbf7f7b4e2ae40 Markus Franke 2012-05-26 366 fbf7f7b4e2ae40 Markus Franke 2012-05-26 367 return sizeof(w1_enable_crccheck); fbf7f7b4e2ae40 Markus Franke 2012-05-26 368 } fbf7f7b4e2ae40 Markus Franke 2012-05-26 369 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
