From: Peter Zijlstra <[EMAIL PROTECTED]> Date: Thu, 08 Nov 2007 21:19:08 +0100
> > On Thu, 2007-11-08 at 10:31 -0800, Christoph Lameter wrote: > > On Thu, 8 Nov 2007, Peter Zijlstra wrote: > > > > > I don't like those shouting macros. > > > > The convention for macros is to use upper case. > > We have plent macros that look like regular functions. And as a primary > interface to this functionality these shouting things look really out of > place. I disagree, macros in upper case make sense here. Macros should SHOUT at you because CPP is MAGIC and has side effects that normal real functions do not have, and therefore you need to be REMINDED. And, honestly, aren't there more important issues about his patches to review than macro capitalization? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
