On Mon, 24 Aug 2020, Dmitry Osipenko wrote: > 24.08.2020 10:33, Lee Jones пишет: > >> ... > >>>> +static struct a500_ec *a500_ec_scratch; > >>> > >>> If this is only used for power_off, please rename it. I've been told to > >>> do so in my driver: > >>> https://lore.kernel.org/lkml/20200519104933.GX271301@dell/ > >> > >> I don't mind to rename the variable, but not sure whether it will be a > >> worthwhile change since _scratch is also a common naming scheme among > >> MFD drivers. Please see max77620_scratch for example, which I added > >> about a year ago. > > > > If something is used once, it does not make it 'common'. > > > > Not sure how this slipped my notice before, but I don't like it. > > > > Ensure any global struct used for power_off only includes items > > required for this purpose. It's unfortunate this API requires a > > global variable at all. > > > > Okay! I'll change it in the v2, thanks! > > Thierry Reding was working on the shutdown API which should replace the > global variables, unfortunately he doesn't have enough time to finish > that work yet.
That would be really good. :) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
