In the function usb_add_hcd(), usb_phy_roothub_alloc()
can return NULL in some cases, so IS_ERR() doesn't meet
the requirements. Thus fix it.
Signed-off-by: Zhang Shengju <zhangshen...@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tang...@cmss.chinamobile.com>
---
 drivers/usb/core/hcd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index aa45840d8..b73a92ee1 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2633,8 +2633,9 @@ int usb_add_hcd(struct usb_hcd *hcd,
 
        if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
                hcd->phy_roothub = usb_phy_roothub_alloc(hcd->self.sysdev);
-               if (IS_ERR(hcd->phy_roothub))
-                       return PTR_ERR(hcd->phy_roothub);
+               if (IS_ERR_OR_NULL(hcd->phy_roothub))
+                       return hcd->phy_roothub ?
+                                       PTR_ERR(hcd->phy_roothub) : -ENODEV;
 
                retval = usb_phy_roothub_init(hcd->phy_roothub);
                if (retval)
-- 
2.20.1.windows.1



Reply via email to