On Wed, Aug 19, 2020 at 05:43:29PM -0600, David Fugate wrote: > There were queries? My key takeaways were a maintainer NAK followed by > instructions to make the Intel drive align with the driver by > implementing NOIOB. While I disagree with the rejection as it appeared > to be based entirely on politics, I can accept it as the quirk wasn't > in the spec.
Stop the crap now please. I'm really offended. I'm offended by you implying that I pay corporate poitics. I'm primary a Linux developer, and I stand for what I think is good for Linux. I fight inside companies that pay me what is good for Linux, I work hard with companies that do not pay to convinve them what is right. I waste a lot of precious time to sit in standards meetings to do what is right for Linux. And now you come here with the politics arguments. Stop, it please. The Intel NOIOB quirk was in the driver since day 1, added by Matthew probably with no bad intent, but we kept growing the lists and finally got Intel to standardized because it was good for Linux, and to be honest good for Intel as updating quirks in half a dozen drivers simply does not scale. We got a really nice trivial TP out of it. But we really should not see any new drivers that do not implement one damn trivial field a long time after the TP has been publushed. That is not politics. Making a fuzz and playing the corporate card on a Linux mailing list is politics, really bad politics and you need to stop it. > It's not fair to make this same "your drive should align with the > driver" demand of Samsung because we *are* talking about a spec'ed > feature here. Huh. Next time Dell or NetApp or Facebook are going to require an optional NVMe feature, and OCP feature or even a vendor specific feature you are going to go to them and say "you don't play fair"? > Technical critques of their patches and real performance > degrades observed are fair game and objective; "your company did > the nastiest possible move violating the normal NVMe procedures to make > it optional" is not. It is pretty fair game if you know the background, that is that I spent countless hours to make this feature fit the Linux I/O stack requirement perfecty and worked that it is there. We might as well rely on it.
