On Fri, Jul 31, 2020 at 04:33:35PM -0700, Kees Cook wrote: > On Fri, Jul 31, 2020 at 11:21:46AM +0200, Ingo Molnar wrote: > > > > * Arvind Sankar <nived...@alum.mit.edu> wrote: > > > > > On Tue, Jul 28, 2020 at 06:57:01PM -0400, Arvind Sankar wrote: > > > > v2->v3: > > > > - Fix the first patch: command line size should be strlen + 1 to account > > > > for terminating NUL. Avoid calling add_identity_map if cmdline was > > > > NULL, though it should do nothing in that case anyway. > > > > > > Hi Ingo, I noticed that WIP.x86/kaslr and x86/kaslr both have the v2 > > > version of the first patch. That has a bug in the cmd_line_size > > > calculation (missing the +1). > > > > Indeed, well spotted. I rebased the affected 4 patches in x86/kaslr > > and used the opportunity to add Kees's Reviewed-by to the first 4 > > patches as well. > > > > I've zapped tip:x86/kaslr for now and put the whole series into > > tip:WIP.x86/kaslr, will move it into tip:x86/kaslr for a v5.9 merge > > once Kees is happy with the latest version. > > > > Kees, AFAICS your type truncation and patch split-up review > > suggestions were resolved in v3? > > I need to double-check, but I think so. I'm hoping to get to that on > Monday. My orphan section series work took MUCH longer than I thought it > was going to. :P > > -- > Kees Cook
Hey Kees, did you get a chance to review? Thanks.
