Hi Viresh, On Wed, Aug 12, 2020 at 08:31:22PM +0530, Viresh Kumar wrote: > On 12-08-20, 12:53, Stephan Gerhold wrote: > > I have another small build fix reported by the kernel test robot, > > but will wait with sending that out until Viresh had a chance to give > > some feedback on the basic idea. :) > > What was the issue that was reported ? I may end up applying V1 only > with some of my changes. >
It was this build error on SH (for the second patch): >> drivers/cpufreq/cpufreq-dt.c:36:29: error: conflicting types for 'cpu_data' 36 | static struct private_data *cpu_data; | ^~~~~~~~ In file included from arch/sh/include/asm/thread_info.h:27, from include/linux/thread_info.h:38, from include/asm-generic/current.h:5, from ./arch/sh/include/generated/asm/current.h:1, from include/linux/mutex.h:14, from include/linux/notifier.h:14, from include/linux/clk.h:14, from drivers/cpufreq/cpufreq-dt.c:11: arch/sh/include/asm/processor.h:90:26: note: previous declaration of 'cpu_data' was here 90 | extern struct sh_cpuinfo cpu_data[]; | ^~~~~~~~ I fixed it by renaming "cpu_data" to "cpufreq_dt_data". (I could not think of a better name so feel free to use something else...) Thanks! Stephan