On Wed, 2020-08-12 at 11:29 +0800, Zhang Rui wrote: > Hi, > > Thanks for reviewing. > > On Tue, 2020-08-11 at 11:19 -0700, Joe Perches wrote: > > On Tue, 2020-08-11 at 23:31 +0800, Zhang Rui wrote: > > > There will be more platforms with different fixed energy units. > > > Enhance the code to support different rapl unit quirks for > > > different > > > platforms. > > > > This seems like one quirk per platform. > > > > Should multiple quirks on individual platforms be supported? > > > enum rapl_unit_quirk is just used as a flag. > multiple quirks can be deployed with the same flag, just like what I > did in patch 3/3. > Also different platforms can either have different flags or share the > same flag.
Sure, but it does lead to possible code duplication in the quirks as enums can not be combined like bit flags. No worries, your code, your choice...
