-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Serge E. Hallyn wrote: > Quoting Stephen Smalley ([EMAIL PROTECTED]): >> On Wed, 2007-10-31 at 18:49 -0500, Serge E. Hallyn wrote: [..] >>> Also don't do file-capabilities signaling checks when uids for >>> the processes don't match, since the standard check_kill_permission >>> will have done those checks. >> Description doesn't match the code. > > Egads. I knew I should've just kept that part out of it for the first > patch... > > New patch on top of previous one is appended.
Dang! I stared at the code a long time to see what you were doing... And concluded that you had coded what you intended; allow processes that share UIDs to kill one another - independent of capabilities. The fact that this is the reverse of the words you used to introduce your patch, I didn't notice. I totally missed the fact that this was (unwanted) new functionality!! Mea culpa for the bad review. I certainly Sign off the revised patch. Cheers Andrew -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHLOicmwytjiwfWMwRAq5HAJ49eajMT4myf1oKfrab2oCw/o9HnwCgkYt2 RyIsmHVWmClsrxCz5s1HRJY= =hGLO -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/