From: Tiezhu Yang <yangtie...@loongson.cn>

[ Upstream commit dbec37048d27cee36e103e113b5f9b1852bfe997 ]

Check the return value of irq_domain_translate_onecell() due to
it may returns -EINVAL if failed.

Fixes: 818e915fbac5 ("irqchip: Add Loongson HyperTransport Vector support")
Signed-off-by: Tiezhu Yang <yangtie...@loongson.cn>
Signed-off-by: Marc Zyngier <m...@kernel.org>
Link: 
https://lore.kernel.org/r/1594087972-21715-5-git-send-email-yangtie...@loongson.cn
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/irqchip/irq-loongson-htvec.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-loongson-htvec.c 
b/drivers/irqchip/irq-loongson-htvec.c
index b36d403383230..720cf96ae90ee 100644
--- a/drivers/irqchip/irq-loongson-htvec.c
+++ b/drivers/irqchip/irq-loongson-htvec.c
@@ -109,11 +109,14 @@ static struct irq_chip htvec_irq_chip = {
 static int htvec_domain_alloc(struct irq_domain *domain, unsigned int virq,
                              unsigned int nr_irqs, void *arg)
 {
+       int ret;
        unsigned long hwirq;
        unsigned int type, i;
        struct htvec *priv = domain->host_data;
 
-       irq_domain_translate_onecell(domain, arg, &hwirq, &type);
+       ret = irq_domain_translate_onecell(domain, arg, &hwirq, &type);
+       if (ret)
+               return ret;
 
        for (i = 0; i < nr_irqs; i++) {
                irq_domain_set_info(domain, virq + i, hwirq + i, 
&htvec_irq_chip,
-- 
2.25.1

Reply via email to