+Marc Z On Tue, Aug 04, 2020 at 04:56:57PM +0800, Jason Liu wrote: > No need to do the irq_chip->irq_mask() if it already masked. > BTW, unconditionally do the irq_chip->irq_mask() will also bring issues > when the irq_chip in the runtime PM suspend. Accessing registers of the > irq_chip will bring in the exceptions. For example on the i.MX: >
The change looks good and is inline with the additional checks we do for eoi and disable. However, the imx_irqsteer_irq_mask is not safe to be called with runtime suspend. What happens if some driver using the irq on this chip calls disable_irq when this irqchip is suspended ? -- Regards, Sudeep
