I agree with you. Actually there are some false warnings not mentioned in my patch, such as:
case xxx: { if () { return; } else { if () { return; } else { return; } } } case xxx: ... Since compiler can do this now, I think this test should be removed. Regards, Cambda > 在 2020年8月1日,02:05,Joe Perches <j...@perches.com> 写道: > > On Wed, 2020-07-29 at 20:59 +0800, Cambda Zhu wrote: >> The checkpatch.pl only searches 3 previous lines when finding missing >> switch/case break, and macros are treated as normal statements. If the >> cases are surrounded with CONFIG, checkpatch.pl may report false >> warnings. For example: > > Likely this test should be removed altogether as > it's never really worked well and now compilers > find this and emit warnings.