Hi Matthias,
thanks for the patch.
On 20-07-28 13:28, Matthias Schiffer wrote:
> In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS, add the
> QSPI controller to imx7s.dtsi.
>
> Based-on-patch-by: Han Xu <han...@nxp.com>
> Signed-off-by: Matthias Schiffer <matthias.schif...@ew.tq-group.com>
> ---
> arch/arm/boot/dts/imx7s.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 1cfaf410aa43..e45683e61593 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -1162,6 +1162,19 @@
> status = "disabled";
> };
>
> + qspi1: spi@30bb0000 {
Are there more controllers and why not using "qspi@30bb0000" as node
name?
> + #address-cells = <1>;
> + #size-cells = <0>;
> + compatible = "fsl,imx7d-qspi";
> + reg = <0x30bb0000 0x10000>, <0x60000000
> 0x10000000>;
> + reg-names = "QuadSPI", "QuadSPI-memory";
The node should begin with compatible, reg, reg-names properties.
Pls check the current .dtsi file for examples.
> + interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks IMX7D_QSPI_ROOT_CLK>,
> + <&clks IMX7D_QSPI_ROOT_CLK>;
> + clock-names = "qspi_en", "qspi";
> + status = "disabled";
> + };
> +
> sdma: sdma@30bd0000 {
> compatible = "fsl,imx7d-sdma", "fsl,imx35-sdma";
> reg = <0x30bd0000 0x10000>;
Regards,
Marco
