Hi, On Wed, Jul 15, 2020 at 10:55:12PM +0800, Crag Wang wrote: > This is a long life mode set in the factory for extended warranty > battery, the power charging rate is customized so that battery at > work last longer. > > Presently switching to a different battery charging mode is through > EC PID 0x0710 to configure the battery firmware, this operation will > be blocked by EC with failure code 0x01 when PLL mode is already > in use. > > Signed-off-by: Crag Wang <crag.w...@dell.com> > --- > Documentation/ABI/testing/sysfs-class-power-wilco | 3 +++ > drivers/power/supply/power_supply_sysfs.c | 1 + > drivers/power/supply/wilco-charger.c | 5 +++++ > include/linux/power_supply.h | 1 + > 4 files changed, 10 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-class-power-wilco > b/Documentation/ABI/testing/sysfs-class-power-wilco > index da1d6ffe5e3c..1c91b17b6fd4 100644 > --- a/Documentation/ABI/testing/sysfs-class-power-wilco > +++ b/Documentation/ABI/testing/sysfs-class-power-wilco > @@ -14,6 +14,9 @@ Description: > Charging begins when level drops below > charge_control_start_threshold, and ceases when > level is above charge_control_end_threshold. > + Permanent Long Life: Last longer battery life, this mode > + is programmed once in the factory. Switching to a > + different mode is unavailable.
The documentation lacks one important aspect: What happens
if I have a device where the factory did not program "Long Life"?
I.e. what happens when
# cat /sys/class/power_supply/wilco-charger/charge_type
Standard
# echo "Long Life" > /sys/class/power_supply/wilco-charger/charge_type
Will the controller switch into permanent long life battery mode
without any exit strategy?
> What:
> /sys/class/power_supply/wilco-charger/charge_control_start_threshold
> Date: April 2019
> diff --git a/drivers/power/supply/power_supply_sysfs.c
> b/drivers/power/supply/power_supply_sysfs.c
> index bc79560229b5..af3884015ad8 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -87,6 +87,7 @@ static const char * const POWER_SUPPLY_CHARGE_TYPE_TEXT[] =
> {
> [POWER_SUPPLY_CHARGE_TYPE_STANDARD] = "Standard",
> [POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE] = "Adaptive",
> [POWER_SUPPLY_CHARGE_TYPE_CUSTOM] = "Custom",
> + [POWER_SUPPLY_CHARGE_TYPE_LONGLIFE] = "Permanent Long Life",
The "Permanent" part is specific to the Wilco EC, so I think it's
better to avoid it in the generic API. I think it's better to use
just "Long Life" (and keep the wilco specific sysfs Documentation,
that Long Life configuration is permanent).
-- Sebastian
> };
>
> static const char * const POWER_SUPPLY_HEALTH_TEXT[] = {
> diff --git a/drivers/power/supply/wilco-charger.c
> b/drivers/power/supply/wilco-charger.c
> index b3c6d7cdd731..713c3018652f 100644
> --- a/drivers/power/supply/wilco-charger.c
> +++ b/drivers/power/supply/wilco-charger.c
> @@ -27,6 +27,7 @@ enum charge_mode {
> CHARGE_MODE_AC = 3, /* Mostly AC use, used for Trickle */
> CHARGE_MODE_AUTO = 4, /* Used for Adaptive */
> CHARGE_MODE_CUSTOM = 5, /* Used for Custom */
> + CHARGE_MODE_LONGLIFE = 6, /* Used for Permanent Long Life */
> };
>
> #define CHARGE_LOWER_LIMIT_MIN 50
> @@ -48,6 +49,8 @@ static int psp_val_to_charge_mode(int psp_val)
> return CHARGE_MODE_AUTO;
> case POWER_SUPPLY_CHARGE_TYPE_CUSTOM:
> return CHARGE_MODE_CUSTOM;
> + case POWER_SUPPLY_CHARGE_TYPE_LONGLIFE:
> + return CHARGE_MODE_LONGLIFE;
> default:
> return -EINVAL;
> }
> @@ -67,6 +70,8 @@ static int charge_mode_to_psp_val(enum charge_mode mode)
> return POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE;
> case CHARGE_MODE_CUSTOM:
> return POWER_SUPPLY_CHARGE_TYPE_CUSTOM;
> + case CHARGE_MODE_LONGLIFE:
> + return POWER_SUPPLY_CHARGE_TYPE_LONGLIFE;
> default:
> return -EINVAL;
> }
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index ac1345a48ad0..528a3eaa2320 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -48,6 +48,7 @@ enum {
> POWER_SUPPLY_CHARGE_TYPE_STANDARD, /* normal speed */
> POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE, /* dynamically adjusted speed */
> POWER_SUPPLY_CHARGE_TYPE_CUSTOM, /* use CHARGE_CONTROL_* props */
> + POWER_SUPPLY_CHARGE_TYPE_LONGLIFE, /* slow speed, longer life */
> };
>
> enum {
> --
> 2.17.1
>
> ---
> The original author, Nick no longer being around and that's why he's not on
> CC.
signature.asc
Description: PGP signature
