On 29/10/07 17:02 -0700, H. Peter Anvin wrote: > Jordan Crouse wrote: > > From: Jordan Crouse <[EMAIL PROTECTED]> > > > > A relatively recent version of the Geode LX datasheet listed the wrong > > address for one of the MSRs that controls TFT panels, resulting in > > breakage. This patch corrects the MSR address. > > > > Signed-off-by: Jordan Crouse <[EMAIL PROTECTED]> > > --- > > > > drivers/video/geode/lxfb.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/video/geode/lxfb.h b/drivers/video/geode/lxfb.h > > index 6c227f9..ca13c48 100644 > > --- a/drivers/video/geode/lxfb.h > > +++ b/drivers/video/geode/lxfb.h > > @@ -33,7 +33,7 @@ void lx_set_palette_reg(struct fb_info *, unsigned int, > > unsigned int, > > > > #define MSR_LX_GLD_CONFIG 0x48002001 > > #define MSR_LX_GLCP_DOTPLL 0x4c000015 > > -#define MSR_LX_DF_PADSEL 0x48000011 > > +#define MSR_LX_DF_PADSEL 0x48002011 > > #define MSR_LX_DC_SPARE 0x80000011 > > #define MSR_LX_DF_GLCONFIG 0x48002001 > > > > Please put MSR indicies in <asm-x86/msr-index.h> and/or a separate > include file.
The Geode has zillions upon zillions of MSRs (all of them being Geode specific), so putting them in asm-x86/msr-index.h would be a bad idea for both you and me. But tossing them into a asm-x86/geode-msr.h file would be good for 2.6.25. I'll get working on that. In the mean time, this particular #define is already in the tree, and this patch fixes serious breakage, so I would really like to see it hit 2.6.24, if we can. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
