> -----Original Message----- > From: Greg KH <[email protected]> > Sent: Friday, July 24, 2020 4:32 PM > To: Bard Liao <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; Kale, Sanyog > R <[email protected]>; Lin, Mengdong <[email protected]>; > Liao, Bard <[email protected]> > Subject: Re: [PATCH] soundwire: master: enable pm runtime > > On Thu, Jul 23, 2020 at 09:49:02PM +0800, Bard Liao wrote: > > We should enable pm runtime. > > Because why?
The hierarchy of soundwire devices is platform device -> M device -> S device. A S device is physically attached on the platform device. So the platform device should be resumed when a S device is resumed. As the bridge of platform device and S device, we have to implement runtime pm on M driver. We have set runtime pm ops in M driver already, but still need to enable runtime pm. > > Please read the documentation about how to write good changelog > comments... Sure. I will update the changelog in next version. Thanks for the advice. > > greg k-h
