On Mon, 29 Oct 2007 13:35:33 +0100 Johannes Stezenbach wrote: > On Mon, Oct 29, 2007, Ingo Molnar wrote: > > * Randy Dunlap <[EMAIL PROTECTED]> wrote: > > > > > > config VIDEO_SAA7146_VV > > > > tristate > > > > depends on VIDEO_DEV = y || VIDEO_DEV = VIDEO_SAA7146_VV > > > > select VIDEOBUF_DMA_SG > > > > select VIDEO_SAA7146 > > > > > > > > (untested) > > > > > > Nope, won't work. I tried that last night. VIDEO_DEV_SAA7146_VV > > > has too many "select"s involved, but select doesn't follow the dependency > > > chains. IOW, as written in Documentation/kbuild/kconfig-language.txt: > > > > > > select is evil.... select will by brute force set a symbol > > > equal to 'y' without visiting the dependencies. So abusing > > > select you are able to select a symbol FOO even if FOO depends > > > on BAR that is not set. > > > > so ... what should we do? Remove those ~7 select VIDEO_SAA7146_VV lines > > and replace them with depends on VIDEO_SAA7146_VV ? > > Hm, the idea is that the SAA7146 driver is like a library, > and the V4L or DVB card drivers select the library functions > they need (base driver or common V4L helper functions). > The user shouldn't have to worry about those details. > > But yeah, if it's not possible to do that with kbuild then > it's probably best to s/select/depends on/ for VIDEO_SAA7146_VV > and provide a meaningful help text for VIDEO_SAA7146_VV.
I don't have a better suggestion, but VIDEO_SAA7146_VV will need a prompt and help text if a user can enable/disable it. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
