Hi, Linus
> Subject: Re: [PATCH 1/3] gpio: mxc: Support module build
>
> On Wed, Jul 8, 2020 at 1:28 AM Anson Huang <anson.hu...@nxp.com>
> wrote:
>
> > subsys_initcall(gpio_mxc_init);
> > +
> > +MODULE_AUTHOR("Shawn Guo <shawn....@linaro.org>");
> > +MODULE_DESCRIPTION("i.MX GPIO Driver"); MODULE_LICENSE("GPL");
>
> You are making this modualrizable but keeping the subsys_initcall(), which
> doesn't make very much sense. It is obviously not necessary to do this probe
> at subsys_initcall() time, right?
>
If building it as module, the subsys_initcall() will be equal to module_init(),
I keep
it unchanged is because I try to make it identical when built-in, since most of
the
config will still have it built-in, except the Android GKI support. Does it
make sense?
> Take this opportunity to convert the driver to use
> module_platform_driver() as well.
If you think it has to be or it is better to use module_platform_driver(), I
will do
it in V2.
thanks,
Anson
