On Fri, Jul 10, 2020 at 01:24:59PM +0100, Mark Brown wrote: > On Thu, Jul 09, 2020 at 07:41:00PM -0700, Nathan Chancellor wrote: > > > When CONFIG_SND_SOC_ZL38060 is y, MODULE_DEVICE_TABLE expands to nothing > > so zl38_dt_ids will be unused. This is a pretty common construct in the > > kernel and the only way I can think of to resolve this through the code > > is by adding __used annotations to all of these variables, which I think > > is overkill for this. > > > Personally, I think this warning should be downgraded to W=2, thoughts? > > We've had that warning available for ever, we shouldn't need to disable > it now. I had thought there was supposed to be magic which caused > of_match_ptr() to make things look referenced when !OF but don't seem to > actually see any sign of it. The other thing is to just have ifdefs > around the table.
While it has been available, it's been hidden behind W=1, which is now default on for 0day. Sure, you could hide it behind an ifdef for either CONFIG_OF or MODULE (since you could build this as a module with CONFIG_OF disabled). I just figured this would be something frowned upon but if that is how you would prefer it to be fixed, then I have no objections to it. Cheers, Nathan
