On Thu, Jul 09, 2020 at 08:31:39PM -0700, Randy Dunlap wrote:
> > +/* this is needed for setting boundery for panic_timeout to prevent it
> > from overflow*/
>
> boundary (or max value)
> overflow */
>
> > +static int panic_time_max = INT_MAX / 1000;
Or just simplify the comment.
/* Prevent overflow in panic() */
Or perhaps better, fix panic() to not overflow.
- for (i = 0; i < panic_timeout * 1000; i += PANIC_TIMER_STEP) {
+ for (i = 0; i / 1000 < panic_timeout; i += PANIC_TIMER_STEP) {
you probably also want to change i to be a long long or the loop may never
terminate.
