* Masami Hiramatsu <mhira...@kernel.org> [2020-07-09 17:07:12]:
> Fix a wrong "variable not found" warning when the probe point is
> not found in the debuginfo.
> Since the debuginfo__find_probes() can return 0 even if it does not
> find given probe point in the debuginfo, fill_empty_trace_arg() can
> be called with tf.ntevs == 0 and it can warn a wrong warning.
> To fix this, reject ntevs == 0 in fill_empty_trace_arg().
>
>
>
> Reported-by: Andi Kleen <a...@firstfloor.org>
> Fixes: cb4027308570 ("perf probe: Trace a magic number if variable is not
> found")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Masami Hiramatsu <mhira...@kernel.org>
Looks good to me.
Reviewed-by: Srikar Dronamraju <sri...@linux.vnet.ibm.com>
> ---
> tools/perf/util/probe-finder.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 55924255c535..9963e4e8ea20 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -1408,6 +1408,9 @@ static int fill_empty_trace_arg(struct perf_probe_event
> *pev,
> char *type;
> int i, j, ret;
>
> + if (!ntevs)
> + return -ENOENT;
> +
> for (i = 0; i < pev->nargs; i++) {
> type = NULL;
> for (j = 0; j < ntevs; j++) {
>
--
Thanks and Regards
Srikar Dronamraju
