On Thu, Jul 2, 2020 at 9:12 AM Anson Huang <anson.hu...@nxp.com> wrote: > > > > The question is whether the #ifdef check in the header to test for MODULE > > (only calling it if this particular soc has a built-in clk driver, which is > > sufficient) > > or for IS_MODULE(CONFIG_MXC_CLK) (call it if _any_ clk driver is built-in > > and > > the function exists, which leaves extra code in the driver but is a more > > conventional check). > > > > So you prefer to add an empty inline function for imx_register_uart_clocks() > with check > of MODULE build?
Yes, I want the empty inline stub, but either symbol check would work > Even with this, we still need to add MODULE build check to whole block > of this earlycon uart clock handler in imx/clk.c. Correct. Arnd