On 30/06/2020 17:09, Zhang Rui wrote: > Hi, Daniel, > > seems that you forgot to cc linux-pm mailing list. > > On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote: >> On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano >> <daniel.lezc...@linaro.org> wrote: >>> >>> The cdev, tz and governor list, as well as their respective locks >>> are >>> statically defined in the thermal_core.c file. >>> >>> In order to give a sane access to these list, like browsing all the >>> thermal zones or all the cooling devices, let's define a set of >>> helpers where we pass a callback as a parameter to be called for >>> each >>> thermal entity. >>> >>> We keep the self-encapsulation and ensure the locks are correctly >>> taken when looking at the list. >>> >>> Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> >>> --- >>> drivers/thermal/thermal_core.c | 51 >>> ++++++++++++++++++++++++++++++++++ >> >> Is the idea to not use thermal_helpers.c from now on? It fits >> perfectly with a patch I have to merge all its contents to >> thermal_core.c :-) > > I agree these changes should be in thermal_helper.c
Oh, actually I remind put those functions in the thermal_core.c file because they need the locks which are statically defined in there. If the functions are moved to thermal_helper.c that will imply to export the locks outside of the file, thus breaking the self-encapsulation. Do you want to move them out? -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
