On Tue, Jun 23, 2020 at 9:06 AM Sungbo Eo <man...@gorani.run> wrote: > > This patch adds support for the PCA9570 I2C GPO expander.
> Tested in kernel 5.4 on an ipq40xx platform. > > This is my first time submitting a whole driver patch, and I'm not really > familiar with this PCA expander series. > Please let me know how I can improve this patch further. (Do I also need to > document the DT compatible string?) > > FYI there's an unmerged patch for this chip. > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2017-May/105602.html > I don't have PCA9571 either so I didn't add support for it. My very first questions to such (simple) driver submissions is: Have you conducted research of existing drivers and found that none is suitable for this chip? Do this and answer in a commit message, if it will be still valid. -- With Best Regards, Andy Shevchenko
